Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fix: OpenFAST ServoDyn input file syntax #966

Merged
merged 1 commit into from
Apr 19, 2022
Merged

Bug fix: OpenFAST ServoDyn input file syntax #966

merged 1 commit into from
Apr 19, 2022

Conversation

rafmudaf
Copy link
Contributor

@rafmudaf rafmudaf commented Apr 19, 2022

Pull-request type:

  • Bug fix
  • Documentation update
  • Feature enhancement

Description of the pull-request

Removes an extra and invalid section of the ServoDyn input file for the OpenFAST-coupled regression tests.

Tested with OpenFAST standalone (switched the inflow conditions to steady wind) and it runs successfully after compiling the controller library.

Checklist

NOTE The checklist below is a suggestion and not mandatory. You don't have
to check all boxes to submit a pull request. However, please add a brief
explanation in your pull request summary explaining the omission for the benefit
of reviewers and developers.

All pull requests

  • Builds successfully (must test on at least one system/compiler combination)
    • Operating systems
      • Linux
      • MacOS
    • Compilers
      • GCC
      • LLVM/Clang
      • Intel compilers
      • NVIDIA CUDA
  • Compiles without warnings
  • Passes all unit tests
  • Passes all regression tests
  • Documentation builds without errors

For new code updates

  • Documentation updates - additions to user, theory, and verification manuals
  • New unit tests providing coverage for new code, bug fixes etc.
  • New regression tests exercising the new code

@jrood-nrel jrood-nrel merged commit c8e5c1e into Exawind:master Apr 19, 2022
@rafmudaf
Copy link
Contributor Author

FWIW I've improved the documentation in OpenFAST because of these failing tests in Nalu, so its not been for nothing :)
OpenFAST/openfast#1101

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants