Display error message to user if project is using NuGet PackageReference #264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is great - thanks @augustoproiete Would you like to have a discussion on how we can support .NET Standard projects? |
augustoproiete
deleted the
display-error-when-using-nuget-packagereference
branch
|
@govert Sure, I've sent you an e-mail. |
|
I've been using PackageReference successfully until this check was added. It worked without any tweaks to build scripts and I was able to build my solution directly from command line after cloning via git |
|
@y2kbugger In the updated package version 1.1.1, @augustoproiete added an extra flag in the .targets file to support this scenario, so that you don't have to fiddle with any of the package scripts. See PR and discussion #327 . Let us know whether you get that to work right. |
|
Oh that sounds like what I need. I'll try it tomorrow after I figure out
what I think is a gac issue. Updating Excel DNA was a futile attempt at
fixing after exhausting normal debugging.
…On Wed, Aug 12, 2020, 18:23 Govert van Drimmelen ***@***.***> wrote:
@y2kbugger <https://github.com/y2kbugger> In the updated package version
1.1.1, @augustoproiete <https://github.com/augustoproiete> added an extra
flag in the .targets file to support this scenario, so that you don't have
to fiddle with any of the package scripts. See PR and discussion #327
<#327> . Let us know whether
you get that to work right.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#264 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABORVLPFSXEEOW27V6QD5PDSAMI5ZANCNFSM4JE6DVIQ>
.
|
|
I can confirm that this works for me. Thanks!
…On Wed, Aug 12, 2020 at 10:32 PM Zak Kohler ***@***.***> wrote:
Oh that sounds like what I need. I'll try it tomorrow after I figure out
what I think is a gac issue. Updating Excel DNA was a futile attempt at
fixing after exhausting normal debugging.
On Wed, Aug 12, 2020, 18:23 Govert van Drimmelen ***@***.***>
wrote:
> @y2kbugger <https://github.com/y2kbugger> In the updated package version
> 1.1.1, @augustoproiete <https://github.com/augustoproiete> added an
> extra flag in the .targets file to support this scenario, so that you don't
> have to fiddle with any of the package scripts. See PR and discussion
> #327 <#327> . Let us know
> whether you get that to work right.
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <#264 (comment)>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/ABORVLPFSXEEOW27V6QD5PDSAMI5ZANCNFSM4JE6DVIQ>
> .
>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've been receiving an increasing number of support requests from users that create projects that use the
PackageReferencestyle, which is not compatible with Excel-DNA as of this writing (#138).This PR detects if the Excel-DNA add-in project is using the
PackageReferencestyle and displays an error message during build, with instructions on how to resolve the issue:The error message above is displayed just before compilation starts, when:
Class Library (.NET Standard)project (a.k.a. SDK-style project)Class Library (.NET Framework)project, but uses thePackageReferencestyle instead ofpackages.configRelated links: