addpair/addcurrency requires xud restart
#1111
Assignees
Labels
Comments
ghost
self-assigned this
|
Additionally, I think we should add Trading pair: BTC/DAI to the hardcoded standard pairs with the simnet/testnet & mainnet contract addresses. EDIT: separated this into it's own issue (#1114) which we'll do first. Then we can postpone above logic. |
Closed
kilrau
added
enhancement
kilrau
changed the title
addpair requires xud restart
kilrau
changed the title
addpair requires xud restartaddpair/addcurrency requires xud restart
|
This issue includes #1498. |
|
Moshe is waiting for this feature to simplify simulation tests, so let's prioritize it |
sangaman
added a commit
that referenced
this issue
Jul 23, 2020
This PR allows for adding Connext and Lnd currencies via the `AddCurrency` rpc call and have them available for trading immediately without requiring a restart of xud. In the case of Connext it merely registers the tokenaddress and currency symbol for the new currency with the existing ConnextClient, as we had previously done with Raiden. In the case of Lnd, we read from the configuration and use that to instantiate and initialize a new `LndClient` for the specified currency. Closes #1111.
sangaman
added a commit
that referenced
this issue
Jul 24, 2020
This PR allows for adding Connext and Lnd currencies via the `AddCurrency` rpc call and have them available for trading immediately without requiring a restart of xud. In the case of Connext it merely registers the tokenaddress and currency symbol for the new currency with the existing ConnextClient, as we had previously done with Raiden. In the case of Lnd, we read from the configuration and use that to instantiate and initialize a new `LndClient` for the specified currency. Closes #1111.
sangaman
added a commit
that referenced
this issue
Oct 19, 2020
This PR allows for adding Connext and Lnd currencies via the `AddCurrency` rpc call and have them available for trading immediately without requiring a restart of xud. In the case of Connext it merely registers the tokenaddress and currency symbol for the new currency with the existing ConnextClient, as we had previously done with Raiden. In the case of Lnd, we read from the configuration and use that to instantiate and initialize a new `LndClient` for the specified currency. Closes #1111. Co-authored-by: Le Premier Homme <interjoint1@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I just noticed that in our
xud-dockersetup we're adding the trading pairs after connecting to the test nodes. This results in a state where we have the trading pairs enabled, but have 0 orders for the new pairs. The current solution is to restart xud.I'd love this to work without the need for xud restart.
The text was updated successfully, but these errors were encountered: