Support c-lightning as swap client

[kilrau]

Code base: https://github.com/ElementsProject/lightning
Docs: https://lightning.readthedocs.io/

Todo:

1. implement ClightningClient as SwapClient
2. there is no suitable hold invoice plugin to directly support our use case, but hold invoices are implemented by e.g. https://github.com/lightningd/plugins/blob/ea8e24eb5643db5c2693f4d24cb304a009533492/jitrebalance/jitrebalance.py & https://github.com/lightningd/plugins/blob/3290e4e45695393430dd9efe9ee767fa9f38e004/noise/noise.py (thanks @cdecker). Hold invoice hook is implemented since invoice hook ElementsProject/lightning#2540. Opened a separate issue for c-lightning swap hold-invoice plugin: Hold invoice for swaps lightningd/plugins#98
3. make an experimental ltc/btc or even btc/btc swap work (with lnd)

Ignore for now: L-BTC/Liquid support, backups etc

• Here the PR implementing Liquid support (only L-BTC, no Liquid Assets yet): elements: Add support of Liquid-BTC on elements ElementsProject/lightning#3078
• Slight differences in transaction and block formats will need adjustements in our locktime, delta, slippage calculations
• An updated fee estimation mechanism to account for the proofs and the additional fee outputs
  https://medium.com/blockstream/getting-started-with-lightning-on-the-liquid-network-8b5682752ffe (?)
• https://mm.fulmo.org/fulmo/channels/x-backup-plugin-c-lightning

[john-light]

Noting in case it's helpful that a BTC <> L-BTC swap is interesting to me, even before c-lightning supports Liquid Assets

[kilrau]

We just bumped the prio on this one :) @john-light

[kilrau]

Not sure if you are following our discussion in https://mm.fulmo.org/fulmo/channels/c-lightning, but looks like we need two things to support c-lightning with xud: c-lightning integration into xud (#1281) and a hold invoice plugin tight to our use case (lightningd/plugins#98)

Two ways to enforce the payment locktimes in c-lightning:

1. getroute + sendpay, basically the sendtoroute of lnd which we used before
2. encode the last hop cltv into the invoice which is generated by our hold invoice plugin

There doesn't seem to be a good way to set a cltv with the regular pay call (https://lightning.readthedocs.io/lightning-pay.7.html) according to docs & @cdecker

Which one do you think is better? @sangaman @michael1011

[3nprob]

Justr curious to hear if there has been any progress here since the last post?

@kilrau While the pay command doesn't take cltv as an input , invoice now does. Would tha tbe sufficient? ElementsProject/lightning@1a89781#diff-a59e947277b5a6f8696529091c84a49882df40952df323db08e34f11c181bf9d

Also curious of there is/was ny actual WIP on lightningd/plugins#98 that one could pick up on?

[BitcoinOG]

Hi there! Active development moved to https://github.com/opendexnetwork/opendexd now, I already transferred this issue: opendexnetwork/opendexd#2