Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Easy way to cancel orders in CLI #1878

Closed
michael1011 opened this issue Sep 8, 2020 · 4 comments · Fixed by #1910
Closed

Easy way to cancel orders in CLI #1878

michael1011 opened this issue Sep 8, 2020 · 4 comments · Fixed by #1910
Assignees
Labels
command line (CLI) Relating to the command line interface tools P2 mid priority

Comments

@michael1011
Copy link
Contributor

As CLI user I am missing an easy way to cancel my own orders. Right now I have to xucli listorders -j, find my order and the its ID and copy paste it into xucli removeorder <id> which is tedious right now and will be nearly impossible to do once there are more orders on the network

@michael1011 michael1011 added P2 mid priority command line (CLI) Relating to the command line interface tools labels Sep 8, 2020
@michael1011 michael1011 changed the title Easy way to cancel orders Easy way to cancel orders in CLI Sep 8, 2020
@kilrau kilrau self-assigned this Sep 8, 2020
@kilrau
Copy link
Contributor

kilrau commented Sep 8, 2020

I guess the UI will be the better place to cancel a particular order. But I agree that a "cancel all open orders" functionality, will think about it some more.

@rsercano
Copy link
Collaborator

If you guys still want to do this, may I take? @kilrau

@kilrau
Copy link
Contributor

kilrau commented Sep 16, 2020

You got it. UX should be something like this:

> xucli cancelallorders
Are you sure you want to cancel all open orders? [Y/n] Y
Cancelled order with id abc123
Cancelled order with id xyz123
Failed to cancel order with id xzy456
No more orders found

I bet we can find issues with higher prio though @rsercano

@rsercano
Copy link
Collaborator

rsercano commented Sep 16, 2020

You got it. UX should be something like this:

> xucli cancelallorders
Are you sure you want to cancel all open orders? [Y/n] Y
Cancelled order with id abc123
Cancelled order with id xyz123
Failed to cancel order with id xzy456
No more orders found

I bet we can find issues with higher prio though @rsercano

Of course, I just couldn't find one except #1668 which literally confuses me a lot 😅 Time to time (when I encounter it) I'm checking it, but just let me know if there's any other issue I can take other than assigned ones which have higher prio

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
command line (CLI) Relating to the command line interface tools P2 mid priority
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants