fix: added new grpc method to easily cancel all orders

[rsercano]

attempts to resolve #1878

Sorry to implement this prior p1 ones, I had already started this, so wanted to complete first.

[sangaman]

See comments.

[sangaman]

This is also definitely not a "fix" commit/PR, should be a feat as it's a new feature.

[rsercano]

This is also definitely not a "fix" commit/PR, should be a feat as it's a new feature.

Yeap sorry, my bad, I literally suck at commit messages.

[rsercano]

Fixed review points could you please take a look at again?

[raladev]

• it should be removeallorders, not cancel, because our command for single order is removeorder;
• error throwing because of attempt of removing order in hold interrupts work of cancelallorders command. (Place 3 orders, start to fill one of them by peer, use cancelallorders command during swap = no removed orders)
  
• it would be good to add info about full or partial removing to output, because order may be removed partially (because another part of order is in hold).

[raladev]

Above

[rsercano]

error throwing because of attempt of removing order in hold interrupts work of cancelallorders command. (Place 3 orders, start to fill one of them by peer, use cancelallorders command during swap = no removed orders)

I actually used behavior of removeOrder except this command always tries to remove entire order quantity. So in this case I guess it makes sense to add failed order ids into output due to on hold ? @sangaman @kilrau @raladev

[kilrau]

Yes. You can simply append the failed cancellations:

cancelled order with id X
cancelled order with id Y
failed to cancel order with id Z due to "on hold"

[sangaman]

error throwing because of attempt of removing order in hold interrupts work of cancelallorders command. (Place 3 orders, start to fill one of them by peer, use cancelallorders command during swap = no removed orders)

I actually used behavior of removeOrder except this command always tries to remove entire order quantity. So in this case I guess it makes sense to add failed order ids into output due to on hold ? @sangaman @kilrau @raladev

My apologies, this actually looks like a bug in the existing removeOrder logic - if it sees there's a hold on an order then it removes any quantity not on hold and then waits for holds to be resolved (if a swap fails, it'll immediately remove the quantity that's no longer on hold). However, the problem is that if there's no quantity that's not on hold, it attempts to remove 0 quantity and that throws an error. So that just needs be fixed, I'll push a fix for it separately.

With that fix the behavior would be that the call immediately goes through and removes all quantity for all orders that isn't on hold - for any holds it will wait and remove any freed up quantity automatically. Does that sound good to everyone?

[kilrau]

for any holds it will wait and remove any freed up quantity automatically

Will the call not return until all quantity is removed? If so, assuming an order is on hold for several minutes for whatever reason, when will the removeorder call return?

[sangaman]

for any holds it will wait and remove any freed up quantity automatically

Will the call not return until all quantity is removed? If so, assuming an order is on hold for several minutes for whatever reason, when will the removeorder call return?

The call returns immediately after its been received, no waiting for holds to expire since those could technically take hours. With the singular remove order call it returns the quantity that's still on hold. Maybe here we could return a boolean indicating whether any orders remain on hold, or possibly a list of orders that are still on hold if we think that may be helpful.

#1921 fixes the bug I mentioned above, once that's merged we can rebase this branch on master and we shouldn't hit that "can't remove 0 quantity" error any longer.

[raladev]

#1921 is merged, @rsercano please do rebase

[raladev]

it would be good to add info about full or partial removing to output, because order may be removed partially (because another part of order is in hold).

can be done only after #1526

So

error throwing because of attempt of removing order in hold interrupts work of cancelallorders command. (Place 3 orders, start to fill one of them by peer, use cancelallorders command during swap = no removed orders)

is last that we need and it should work after the rebase

[rsercano]

Rebased @raladev thanks for checking this out !

[rsercano]

Fixed @sangaman thanks for checking

fixed