feat(rpc): InitSwapClient #1961
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows for xud to initialize a swap client after xud itself has already been initialized using a new rpc command `InitSwapClient`. The swap client must be configured properly and running before it can be initialized. The procedure for initializing is as follows. 1. A swap client type and (optionally) a currency is specified by the `InitSwapClient` request. 2. Xud extracts the deciphered seed from its decrypted node key, this contains the entropy used to generate the master seed/mnemonic. 3. Xud uses the seedutil to convert the deciphered seed back to a mnemonic. For Lnd, it uses this mnemonic to initialize the wallet. Closes #1929.
|
Looks good code wise - needs manual testing by @raladev |
|
I'm closing this in favor of an alternate approach we discussed to automatically initialize any wallets that aren't initialized upon unlocking xud, aligning with how we currently handle the connext wallet. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows for xud to initialize a swap client after xud itself has already been initialized using a new rpc command
InitSwapClient. The swap client must be configured properly and running before it can be initialized. The procedure for initializing is as follows.InitSwapClientrequest.Closes #1929.
Cli usage example:
xucli initclient Lnd LTC