Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(lnd): change gRPC client options #1966

Merged
1 commit merged into from
Nov 9, 2020
Merged

Conversation

ghost
Copy link

@ghost ghost commented Oct 28, 2020

This "fix" enables @reliveyy to access lnd running on the host machine when xud is running within xud-docker environment.

@ghost ghost requested review from sangaman and raladev October 28, 2020 14:17
@kilrau kilrau assigned ghost Oct 28, 2020
@kilrau kilrau added the P1 top priority label Oct 28, 2020
@kilrau kilrau added this to the 1.3.0 milestone Nov 6, 2020
@ghost
Copy link
Author

ghost commented Nov 9, 2020

Going to merge this, but we have to keep in mind that this option is only safe when lnds run in the docker internal network. Using lnds outside of the docker network have to assume that their connection to lnds can be MITM attacked.

CC @sangaman

@ghost ghost merged commit 3fb5f18 into master Nov 9, 2020
@ghost ghost deleted the feat/lnd-grpc-client-options branch November 9, 2020 10:20
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P1 top priority
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants