refactor(rpc): rename reserved TradingLimits fields #1980
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice - let's get it in with the next release then! |
|
we already have identical PR for that - #1954 ) |
True, closing here. |
This renames the `reservedOutbound` and `reservedInbound` fields on the `TradingLimits` call to `reservedSell` and `reservedBuy` respectively.
sangaman
force-pushed
the
rename-trading-limits
branch
from
63e4cf8 to
721e098
Compare
krrprr
approved these changes
Nov 6, 2020
raladev
approved these changes
Nov 6, 2020
ghost
approved these changes
Nov 6, 2020
ghost
merged commit 
|
Thanks @sangaman |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This renames the
reservedOutboundandreservedInboundfields on theTradingLimitscall toreservedSellandreservedBuyrespectively.This is take two for #1946, which was reverted shortly after being merged to prevent conflicts with xud-ui. Whenever the ui project is ready for these new names we should merge this for good.