Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[0.27.0] The tarball on exiv2.org contains macosx files which get installed #627

Closed
cryptomilk opened this issue Jan 2, 2019 · 6 comments

Comments

@cryptomilk
Copy link
Collaborator

cryptomilk commented Jan 2, 2019

Hi,

the tarball http://exiv2.org/builds/exiv2-0.27.0-Source.tar.gz contains hidden MacOSX files. As you're using globbing to install the install headers the macosx files get installed too.

a) Do not use globbing
b) Do not add hidden macosx files to tarballs

cryptomilk added a commit to cryptomilk/exiv2 that referenced this issue Jan 2, 2019
Fixes Exiv2#627

Signed-off-by: Andreas Schneider <asn@cryptomilk.org>
@cryptomilk
Copy link
Collaborator Author

CPack has support for generating package source files including tarballs. If you don't use that yet, you should take a look at https://cliutils.gitlab.io/modern-cmake/chapters/install/packaging.html

@cryptomilk
Copy link
Collaborator Author

@clanmills
Copy link
Collaborator

Happy New Year, Andreas. Yes, we're using CPack to build the bundles. In v0.26, I had my own script and was able to add export DISABLE_COPYFILE=1 to fix this on MacOS-X. CPack is creating the tar.gz with those hidden files and doesn't respect DISABLE_COPYFILE. So this issue has resurfaced because we adopted CPack.

I've been thinking about this quite a lot. I'm going to build source bundles on Linux in future.

Today, I'll create a new source bundle manually to remove the hidden files and update the sha256sum on the website. I'll request Suse to delay publishing the tar-ball with the hidden files.

@D4N
Copy link
Member

D4N commented Jan 2, 2019

This is a duplicate of #620

@D4N D4N closed this as completed Jan 2, 2019
@cryptomilk
Copy link
Collaborator Author

Happy new year Robin!

@clanmills
Copy link
Collaborator

And Happy New Year to you and your lady, Andreas.

Thanks for bringing up this subject. It has been sitting on my TODO list for a few days as it was reported last week. I've done something about #620 and hope to close it tomorrow.

The other matters that you raised today are interesting/curious and obvious candidates for v0.27.1 which is scheduled for 31 March 2019.

I was hoping to have less work and stress in 2019. Clearly not! On the other hand, Exiv2 keeps my brain busy and active. I was reading on New Year's Eve that the last Professor Stephen Hawking's Rule 1 was never give up working. He's right.

cryptomilk added a commit to cryptomilk/exiv2 that referenced this issue Jan 5, 2019
Fixes Exiv2#627

Signed-off-by: Andreas Schneider <asn@cryptomilk.org>
(cherry picked from commit 0b34ccb)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants