fix_1516_include_path #1565
fix_1516_include_path #1565
Conversation
| @@ -79,6 +79,8 @@ if( EXPAT_FOUND ) | |||
| exiv2-xmp | |||
| ${EXPAT_LIBRARIES} | |||
| ) | |||
| target_include_directories(geotag PRIVATE ${CMAKE_BINARY_DIR}) # exv_conf.h | |||
There was a problem hiding this comment.
Hi Robin, I think these two lines are not needed.
We are including the ${CMAKE_BINARY_DIR} globally for all the project targets at CMakeLists.txt:78.
The ${CMAKE_SOURCE_DIR}/include directory is also propagated when we add the dependency of each sample target to the library exiv2:
- On
samples/CMakeLists.txt:128we are adding the dependency to the exiv2 target. - On
src/CMakeLists.txt:150-154we indicated the directoryes which are propagated when some target depends on exiv2.
There was a problem hiding this comment.
oh I see, I'll try to reproduce it on my side ... It should see first the headers specified in the project rather than something you have in /usr/local/inclde
|
I am not able to reproduce this problem on Ubuntu 21.04. Here's what I tried:
Or is this only a macOS problem? |
kevinbackhouse
force-pushed
the
fix_1516_include_path
branch
from
35b4749
to
c82c4d0
Compare
Codecov Report
@@ Coverage Diff @@
## main #1565 +/- ##
=======================================
Coverage 60.78% 60.78%
=======================================
Files 96 96
Lines 18881 18881
Branches 9494 9494
=======================================
Hits 11476 11476
Misses 5115 5115
Partials 2290 2290 Continue to review full report at Codecov.
|
|
@clanmills: All the checks are passing, so I think this is fine to merge. Should it be back-ported to 0.27-maintenance? |
|
@Mergifyio backport 0.27-maintenance |
|
Command
|
fix_1516_include_path (backport #1565)
See #1516.