Stricter date parsing in value.cpp #1720
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
kevinbackhouse
added
the
forward-to-main
hassec
added
bug
prettyPrinter
mergify bot
pushed a commit
that referenced
this pull request
Jun 27, 2021
* Regression test for issue 1713 * Stricter date parsing. * Fix test failure caused by stdout mismatch. (cherry picked from commit ab58026)
hassec
pushed a commit
that referenced
this pull request
Jun 27, 2021
* Regression test for issue 1713 * Stricter date parsing. * Fix test failure caused by stdout mismatch. (cherry picked from commit ab58026)
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1713.
The problem in #1713 is caused by a file containing the date "2005-09-07415". It isn't rejected as an invalid date. Later on, it's printed to a string using
sprintf, causing an out of bounds write. I have improved the parsing logic to reject the invalid date, and also replacedsprintfwithsnprintf.