Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore results in the xmpsdk directory #1781

Merged
merged 1 commit into from
Jul 16, 2021

Conversation

kevinbackhouse
Copy link
Collaborator

The new CodeQL query that I added in #1771 is producing approximately 200 results in the xmpsdk directory. That's third-party code which we want to avoid changing, so those results aren't useful. This PR makes a small change to the query to ignore results in that directory.

@codecov
Copy link

codecov bot commented Jul 16, 2021

Codecov Report

Merging #1781 (8c80d06) into main (0208b50) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1781   +/-   ##
=======================================
  Coverage   67.48%   67.48%           
=======================================
  Files         151      151           
  Lines       20805    20805           
=======================================
  Hits        14041    14041           
  Misses       6764     6764           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0208b50...8c80d06. Read the comment docs.

@kevinbackhouse kevinbackhouse merged commit 8f126c0 into Exiv2:main Jul 16, 2021
@kevinbackhouse kevinbackhouse added this to the v1.00 milestone Sep 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants