Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Safer casting from double to long in value.hpp (backport #1831) #1837

Merged
merged 2 commits into from
Aug 3, 2021

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Aug 3, 2021

This is an automatic backport of pull request #1831 done by Mergify.


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.io/

(cherry picked from commit 8b844c2)
(cherry picked from commit 372e28c)
@codecov
Copy link

codecov bot commented Aug 3, 2021

Codecov Report

Merging #1837 (4674fae) into main (47de70b) will increase coverage by 0.02%.
The diff coverage is 80.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1837      +/-   ##
==========================================
+ Coverage   60.58%   60.60%   +0.02%     
==========================================
  Files          96       96              
  Lines       18864    18874      +10     
  Branches     9483     9487       +4     
==========================================
+ Hits        11429    11439      +10     
+ Misses       5146     5144       -2     
- Partials     2289     2291       +2     
Impacted Files Coverage Δ
include/exiv2/value.hpp 82.51% <80.00%> (-0.15%) ⬇️
src/tiffvisitor_int.cpp 75.50% <0.00%> (+0.22%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 47de70b...4674fae. Read the comment docs.

@kevinbackhouse kevinbackhouse merged commit 726510f into main Aug 3, 2021
@mergify mergify bot deleted the mergify/bp/main/pr-1831 branch August 3, 2021 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants