Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add doc to release workflow #1861

Merged
merged 1 commit into from
Aug 8, 2021

Conversation

kevinbackhouse
Copy link
Collaborator

@kevinbackhouse kevinbackhouse commented Aug 8, 2021

We weren't running the doxygen step in the "release" workflow.
I have tested this on my fork: https://github.com/kevinbackhouse/exiv2/actions/runs/1110388655

@kevinbackhouse kevinbackhouse added this to the v0.27.5 milestone Aug 8, 2021
@kevinbackhouse kevinbackhouse added the forward-to-main Forward changes in a 0.28.x PR to main with Mergify label Aug 8, 2021
Copy link
Member

@hassec hassec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

Future goal should probably be to somehow directly host the doc somehow so one could have a look at it... But that's a problem for the future :D

@codecov
Copy link

codecov bot commented Aug 8, 2021

Codecov Report

Merging #1861 (2da1bcb) into 0.27-maintenance (e649363) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@                Coverage Diff                @@
##           0.27-maintenance    #1861   +/-   ##
=================================================
  Coverage             46.21%   46.21%           
=================================================
  Files                   146      146           
  Lines                 22874    22874           
  Branches              11762    11762           
=================================================
  Hits                  10572    10572           
  Misses                 6696     6696           
  Partials               5606     5606           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e649363...2da1bcb. Read the comment docs.

@kevinbackhouse kevinbackhouse merged commit bffbb14 into Exiv2:0.27-maintenance Aug 8, 2021
@clanmills clanmills mentioned this pull request Aug 9, 2021
@kevinbackhouse kevinbackhouse deleted the BuildDoc branch August 11, 2021 14:57
@clanmills clanmills mentioned this pull request Sep 8, 2021
@kevinbackhouse kevinbackhouse restored the BuildDoc branch September 9, 2021 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
forward-to-main Forward changes in a 0.28.x PR to main with Mergify
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants