Fix macOS build failure (backport #1962) #1966
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
(cherry picked from commit cf6566b)
kevinbackhouse
added
build
CI
kevinbackhouse
approved these changes
Oct 17, 2021
Codecov Report
@@ Coverage Diff @@
## 0.27-maintenance #1966 +/- ##
=================================================
Coverage 46.32% 46.32%
=================================================
Files 146 146
Lines 22950 22950
Branches 11781 11781
=================================================
Hits 10632 10632
Misses 6702 6702
Partials 5616 5616 Continue to review full report at Codecov.
|
This was referenced Oct 17, 2021
Merged
|
@clanmills: this one should fix the macOS build issues on 0.27-maintenance. |
clanmills
approved these changes
Oct 19, 2021
|
Thanks for fixing this, @kevinbackhouse. Almost there. Waiting to see how the dust settles with David's src/bmffimage.cpp changes and I hope Milos will build/test them in dt (darktable) Then we'll not be in dt (deadly trouble). |
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automatic backport of pull request #1962 done by Mergify.
Mergify commands and options
More conditions and actions can be found in the documentation.
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refreshwill re-evaluate the rules@Mergifyio rebasewill rebase this PR on its base branch@Mergifyio updatewill merge the base branch into this PR@Mergifyio backport <destination>will backport this PR on<destination>branchAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.io/