Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BMFF Performance boost: don't read boxes we're not interested in (backport #1974) #1975

Merged
merged 1 commit into from
Oct 21, 2021

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Oct 20, 2021

This is an automatic backport of pull request #1974 done by Mergify.
Cherry-pick of 4e587fa has failed:

On branch mergify/bp/0.27-maintenance/pr-1974
Your branch is up to date with 'origin/0.27-maintenance'.

You are currently cherry-picking commit 4e587fa9.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   src/bmffimage.cpp

no changes added to commit (use "git add" and/or "git commit -a")

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/github/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.io/

@kevinbackhouse kevinbackhouse force-pushed the mergify/bp/0.27-maintenance/pr-1974 branch from 94a003f to 07d3f7a Compare October 20, 2021 10:54
@kevinbackhouse kevinbackhouse added this to the v0.27.5 milestone Oct 20, 2021
@codecov
Copy link

codecov bot commented Oct 20, 2021

Codecov Report

Merging #1975 (69f976b) into 0.27-maintenance (1f950b0) will increase coverage by 0.01%.
The diff coverage is 75.00%.

❗ Current head 69f976b differs from pull request most recent head 07d3f7a. Consider uploading reports for the commit 07d3f7a to get more accurate results
Impacted file tree graph

@@                 Coverage Diff                  @@
##           0.27-maintenance    #1975      +/-   ##
====================================================
+ Coverage             46.32%   46.33%   +0.01%     
====================================================
  Files                   146      146              
  Lines                 22950    22957       +7     
  Branches              11781    11784       +3     
====================================================
+ Hits                  10632    10638       +6     
  Misses                 6702     6702              
- Partials               5616     5617       +1     
Impacted Files Coverage Δ
src/bmffimage.cpp 41.84% <75.00%> (+0.82%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1f950b0...07d3f7a. Read the comment docs.

@clanmills clanmills merged commit bfa7f62 into 0.27-maintenance Oct 21, 2021
@clanmills clanmills deleted the mergify/bp/0.27-maintenance/pr-1974 branch October 21, 2021 08:59
@clanmills clanmills changed the title Performance boost: don't read boxes we're not interested in (backport #1974) BMFF Performance boost: don't read boxes we're not interested in (backport #1974) Oct 21, 2021
@clanmills clanmills mentioned this pull request Oct 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants