-
Notifications
You must be signed in to change notification settings - Fork 285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove date from testData file #2079
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2079 +/- ##
==========================================
- Coverage 62.08% 61.87% -0.22%
==========================================
Files 96 96
Lines 19153 19059 -94
Branches 9798 9782 -16
==========================================
- Hits 11891 11792 -99
- Misses 4967 4984 +17
+ Partials 2295 2283 -12
Continue to review full report at Codecov.
|
@piponazo<https://github.com/piponazo>: I am happy to review this but it will have to wait until the weekend.
|
Sure, whenever you have some spare time 😉 |
@piponazo: When I added #2053, I included every tag that was in the XMP IPTC Metadata Standard 2021.1 - which doesn't include The problems in this issue (and in #2083) is that the tags are passing through conversion functions which add or update some of the tags. The error is caused by one of the conversion functions using the local time. This conversion problem has come up before though in #367 (the comments start here). In that issue, the solution was to add:
to the Python test (see tests/bash_tests/test_issue_1054.py). As it looks as though the same problem could reoccur with other files in the future, perhaps it is better to set the default test suite environment to |
@postscript-dev yes, I think I will close this PR because we definitely need to take a deeper look to the root issue. |
[Microsoft] Groups
[cid:TransparentConsumerWelcomeMailNonOutlookTopBanner]
postscript dev added
you to Exiv2!
Use the group to share messages and files, and to coordinate group events.
2 members
Have group discussions
With only one email address to remember, connecting with everyone is easy.
Email the ***@***.***>
[ConversationIcon]
[FilesIcon]
Share your files
Send documents, photos, and links. Everyone wants to see those selfies from your trip!
Share ***@***.***?subject=Share%20a%20file%20with%20the%20group>
Plan group events
Inviting the group is a snap with one email address. You'll never accidentally leave someone off an invitation again.
Create an event<https://support.office.com/en-us/article/create-an-event-on-an-outlook-com-group-calendar-a88408a4-f82b-48b0-89c8-2662d758a407>
[CalendarIcon]
Start exploring group features today
Learn more<https://aka.ms/m365g>
[cid:TransparentConsumerWelcomeMailNonOutlookFooter]
You're receiving this message because you're a member of the Exiv2 group from Microsoft 365.
Report ***@***.******@***.***%0aMessage%20subject:%20postscript%20dev%20added%20you%20to%20the%20Exiv2%20group.&ra=1> | Leave ***@***.***/groupsubscription.ashx?source=WelcomeEmail&action=leave&lgk=7b05339c-ec4f-4188-b228-89c89aab5912> | Privacy Statement<https://go.microsoft.com/fwlink/?LinkId=521839> | Learn more<https://aka.ms/m365g>
© Microsoft Corporation, One Microsoft Way, Redmond, WA 98052 USA
[Microsoft]
|
In #2053 a new test was added and since then I was obtaining failures when running the tests locally.
When running the tests locally, the
DateTimeOriginal
key is printed like this:While the expectation was:
It seems that such time is printed in local time. Since that field is not relevant for the test added in #2053, I think we can just remove it.