Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check that the pointer isn't NULL #2544

Merged
merged 2 commits into from
Mar 12, 2023

Conversation

kevinbackhouse
Copy link
Collaborator

Fixes an issue found by OSS-Fuzz: https://oss-fuzz.com/testcase-detail/5390916631527424

@kevinbackhouse kevinbackhouse added bug OSS-Fuzz Bug reported by https://google.github.io/oss-fuzz/ labels Mar 11, 2023
@ghost
Copy link

ghost commented Mar 11, 2023

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

@codecov
Copy link

codecov bot commented Mar 12, 2023

Codecov Report

Merging #2544 (e0ac920) into main (1697417) will decrease coverage by 0.62%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #2544      +/-   ##
==========================================
- Coverage   64.59%   63.97%   -0.62%     
==========================================
  Files         103      103              
  Lines       22224    22467     +243     
  Branches    10857    10858       +1     
==========================================
+ Hits        14356    14374      +18     
- Misses       5633     5872     +239     
+ Partials     2235     2221      -14     
Impacted Files Coverage Δ
src/matroskavideo.cpp 4.59% <0.00%> (-0.09%) ⬇️

... and 57 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

src/matroskavideo.cpp Outdated Show resolved Hide resolved
@neheb neheb merged commit 518c52c into Exiv2:main Mar 12, 2023
@kevinbackhouse kevinbackhouse deleted the fix-matroska-null-pointer-deref branch March 12, 2023 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug OSS-Fuzz Bug reported by https://google.github.io/oss-fuzz/
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants