Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

github CI: test clang-cl as well for meson #2729

Merged
merged 1 commit into from
Aug 8, 2023
Merged

github CI: test clang-cl as well for meson #2729

merged 1 commit into from
Aug 8, 2023

Conversation

neheb
Copy link
Collaborator

@neheb neheb commented Aug 2, 2023

No description provided.

@ghost
Copy link

ghost commented Aug 2, 2023

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

@codecov
Copy link

codecov bot commented Aug 2, 2023

Codecov Report

Merging #2729 (11fad14) into main (6ea6e2c) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #2729   +/-   ##
=======================================
  Coverage   63.91%   63.91%           
=======================================
  Files         103      103           
  Lines       22312    22312           
  Branches    10805    10805           
=======================================
  Hits        14260    14260           
  Misses       5830     5830           
  Partials     2222     2222           

@neheb
Copy link
Collaborator Author

neheb commented Aug 2, 2023

lld-link: warning: found both wmain and main; using latter

huangqinjin/wmain@f9a8185 is interesting. For meson, I just compile the cpp file as part of exiv2. Maybe I need to switch to doing a static lib...

@kmilos
Copy link
Collaborator

kmilos commented Aug 3, 2023

Can we save/eliminate some jobs somewhere else?

For example, it seems the nightly ones run on every PR/merge instead of once a day...

Signed-off-by: Rosen Penev <rosenp@gmail.com>
Copy link
Collaborator

@kmilos kmilos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@neheb neheb merged commit e1c94a1 into Exiv2:main Aug 8, 2023
107 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants