use ReplaceFileA directly

[neheb]

No description provided.

[ghost]

👇 Click on the image for a new way to code review

Legend

[codecov]

Codecov Report

Merging #2731 (05c88ae) into main (901e8ba) will decrease coverage by 63.90%.
Report is 48 commits behind head on main.
The diff coverage is n/a.

❗ Current head 05c88ae differs from pull request most recent head c682ecc. Consider uploading reports for the commit c682ecc to get more accurate results

@@            Coverage Diff             @@
##             main   #2731       +/-   ##
==========================================
- Coverage   63.89%       0   -63.90%     
==========================================
  Files         103       0      -103     
  Lines       22313       0    -22313     
  Branches    10799       0    -10799     
==========================================
- Hits        14258       0    -14258     
+ Misses       5830       0     -5830     
+ Partials     2225       0     -2225     

see 103 files with indirect coverage changes

[kmilos]

Shouldn't we be using UTF-8 API (if different to the legacy ASCII one) since we are forcing UCRT and UTF-8 locales on Windows now?

[neheb]

UTF-8 is the same as ASCII. It just uses the last bit. The U version is UTF-16.

[kmilos]

Also, do we want this for MINGW and CYGWIN as well, or just MSVC builds?

[neheb]

the current check is fine. virus scanners are a thing on Windows.