switch from custom stringFormat to fmtlib #2769
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2769 +/- ##
==========================================
- Coverage 64.62% 64.57% -0.05%
==========================================
Files 104 104
Lines 22239 22155 -84
Branches 10911 10849 -62
==========================================
- Hits 14371 14306 -65
+ Misses 5626 5610 -16
+ Partials 2242 2239 -3 ☔ View full report in Codecov by Sentry. |
|
How about we just wait for C++20 as min requirement and use std::format straight away? Or code it in a way to use std::format if using C++20 so there is one less dependency? |
neheb
force-pushed
the
fmt
branch
7 times, most recently
from
1ac41a6 to
db8dbda
Compare
neheb
force-pushed
the
fmt
branch
9 times, most recently
from
43e31a2 to
51b29fe
Compare
neheb
force-pushed
the
fmt
branch
6 times, most recently
from
e204e8b to
2efbdf3
Compare
|
remaining error needs to be fixed by @kevinbackhouse I think. |
|
Rebased. |
|
Rebased. |
|
Rebased. |
|
@neheb I think I managed to install GCC 13 for the Cygwin job so this can finally proceed. |
| @@ -126,6 +127,27 @@ jobs: | |||
| meson setup "${{github.workspace}}/build" -Dauto_features=${{matrix.deps}} -Dwarning_level=3 -Dcpp_std=c++20 | |||
| meson compile -C "${{github.workspace}}/build" --verbose | |||
| meson test -C "${{github.workspace}}/build" --verbose | |||
| Cygwin: | |||
There was a problem hiding this comment.
I guess this can be removed if we're happy w/ the other Cygwin action now that could be reverted. Although MSYS is somewhat equivalent, no one really uses it to build/ship exiv2 AFAIK...
There was a problem hiding this comment.
I use MSYS here as it’s less verbose than Cygwin. Plus meson has its own subprojects.
|
Hmm? Not sure what you mean by GCC 13 on Cygwin needed. |
It's been a while, heh? 😉 There is no fmt package on Cygwin, and only GCC (libstdc++) 13 onwards has this feature. |
|
I think the CIFuzz error might fix itself after this is merged. My guess is that OSS-Fuzz is running |
The latter helps to avoid wrong format errors and is simpler to use. Will be replaced by std::format once C++20 becomes mandatory. Signed-off-by: Rosen Penev <rosenp@gmail.com>
Signed-off-by: Rosen Penev <rosenp@gmail.com>
|
hmmm CMAKE_CXX_STANDARD is not being overwritten. |
The latter helps to avoid wrong format errors and is simpler to use. Will be replaced by std::format once C++20 becomes mandatory.