[WIP] Port redmine issues

[D4N]

Please do not merge this yet!

This is the port of the issues 426-800 from redmine from bugfixes-test.sh to the new python test suite. That's about half of the redmine issues, the other half still has to be ported. I would like to port them all in one big PR so that we can check that we have the same test coverage.

The branch of this PR is in the main exiv2 repository, so everyone with write access to exiv2 can push to this branch too. Please do not push -f here! I'll clean the git history up before we merge this.

I'll ask for explicit approvals later on, so please do not approve this. Approving this means "I have verified that we have exactly the same test coverage with the new test suite"

[piponazo]

Ey @D4N what is remaining for this PR? Could we merge it already ?

[D4N]

We can, but it's still incomplete, so I would rather not merge it yet.
This is only the first half of the Redmine issues, the second half has not been ported yet (except for issues 831-937 which are currently stashed in my local copy, waiting to be commited).

[piponazo]

I mentioned that because I thought you were only porting here from 426 to 800. I think there is no need to do everything in one single step. IMHO it is better to do small iterations rather than trying to work on a huge tasks via a single PR. For example, I have already reviewed your changes here and they look fine to me. If we wait few days/weeks more to have the rest of things, I will probably need to review everything again, since it will be difficult to differentiate between the new code and the one that I've already reviewed.

[D4N]

Actually I wanted to make this a "all-in-one-sweep" pr, but small steps won't hurt. Let me clean up the git history a bit (there are some useless commits from me left over) and rebase this on master once I have created the VM pull request (as that should also fix the CentOS build on gitlab).

[piponazo]

I was just my point of view, feel free to do as you please 😉

[D4N]

@piponazo Would it be ok with you if I squased c5f2993, 5602841 and 71008bf? At least my commit from the 3 is useless, and the backslashes look like a mistake to me. I'd squash them into one commit with the message "Fix issues with python strings & literals" and would try to commit it in your name.

[piponazo]

Sure, go ahead!

[D4N]

Done. The gitlab build (actually only the CentOS build) will still fail as #320 is not merged yet.

[piponazo]

@D4N Should not we remove the tests from the bash test-suite? Otherwise we will have duplicated tests

[piponazo]

Is this removing the execution of tests from travis?

[D4N]

No, they are run by make tests. @clanmills added them to the test makefile as newtests

[piponazo]

They are not running, please check the travis CI jobs. Let's continue this discussion in slack

[D4N]

@D4N Should not we remove the tests from the bash test-suite? Otherwise we will have duplicated tests

I'd rather not, as we do not have the same test coverage yet. I would like to port all the issues first, then compute the test coverage, deactivate the bash tests and then recheck the test coverage.

[piponazo]

ah ok, I thought we could remove the tests that have been ported to python without having to disable all the bash tests.