-
Notifications
You must be signed in to change notification settings - Fork 281
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update translations #3013
base: main
Are you sure you want to change the base?
Update translations #3013
Conversation
lbschenkel
commented
Jul 10, 2024
•
edited
Loading
edited
- update exiv2.pot ('update-pot' build target)
- sync translations with Crowdin
- sorted files to make them more diffable (helps with future PRs)
I updated the |
Thanks, we can do it this way as well, will close my PR. Please update LINGUAS and CMakeLists.txt for new languages as well (it, ka, and pt_BR). P.S. One gripe w/ Crowdin - it seems to nuke all the comments and historical information in the po files... |
I've updated all files now. Note that the current workflow (or rather: the lack of it) can lead to accidental loss of translations. The reason is that Crowdin is supposed to be the source of truth for them, so if there's any PR coming where translators are submitting new translations (changes to .po files) then those need at the very least to be uploaded to Crowdin. I did some sanity checks by looking at the commit logs and cross-checking with Crowdin, so I think that's not happening in this particular case. But with any manual process, especially for the unfamiliar, that's bound to happen. Ideally this is what should happen:
I can help setting that up, however I need the buy-in from the maintainers. |
Yes, that's not ideal. In a previous job I was the internationalization expert, so I didn't use the PO files as-is but I built tooling that merged those with the original PO files and kept them sorted as well, so it's more diffable. Unfortunately I don't think I can dedicate enough time for this project to replicate that tooling here. |
To the point that makes me hesitate merging this on main, as it would nuke credits to past contributors, let alone some useful comments... |
Yep, going to do that, I was just doing the Crowdin part before.
To be honest putting those in the PO files was a good idea in the first place, as both PO and POT files are supposed to be generated/maintained by tooling and comments are not supposed to be preserved. It'll complicate having that and using Crowdin at the same time, at least not without having a custom merge step after the download from Crowdin. The direct downloads from Crowdin won't work as-is. Let me try doing a manual PO merge to see if I can preserve those. P.S.: Note that the exact same workflow was done in the other PR for the 0.28 branch. I suppose that the comments were not important in that case, or that nobody noticed? |
Both. I guess it was not a huge deal as we still have that historical information on main. Not sure we want to completely loose it though...
Not sure about this either. Some tools use/show comments as hints to other translators/collaborators IIRC...
I was not happy w/ my attempt, but I hope there is a way to do this... |
Yes, but those comments should be in the source code near the translatable string, and The problem is that any ad-hoc comments put directly in the When using Crowdin specifically, it's better to avoid any changes to There are ways around that, but I'm explaining the simplest workflow that would require the least amount of work. |
f014849
to
4e517de
Compare
Tried once more, now I merged the files with I also sorted the files by message, so future updates will be much easier to diff. I can also commit a shell script that helps with this, it's at least one step towards automating more. |
- update exiv2.pot ('update-pot' build target) - sync translations with Crowdin - sorted files to make them more diffable (helps future PRs)
When we're happy with this PR I can create a new one in that branch that'll restore those comments. |
Thanks, I'll have a closer look at the new po files when I get a chance to pull your branch, doesn't let me do it through the web UI... |