Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmakebeautification #37

Merged
merged 5 commits into from
Aug 23, 2017
Merged

cmakebeautification #37

merged 5 commits into from
Aug 23, 2017

Conversation

a17r
Copy link
Contributor

@a17r a17r commented Aug 22, 2017

Pure style changes, also cleaning up else() and endif() tags.

piponazo
piponazo approved these changes Aug 22, 2017
View reviewed changes
Copy link
Collaborator

@piponazo piponazo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Thanks for this contribution. I was converting to lower case all the cmake commands bit a bit, but I did not spend the time to create a Pull Request changing everything.

I really appreciate this change 🥇

@clanmills
Copy link
Collaborator

clanmills commented Aug 22, 2017 •
edited
Loading

I'd also like to thank @a17r for contribution. Thank You very much, Andreas. @piponazo has been refactoring the CMake code for a few weeks and together you're breathing life and sunshine into a dark hole in the code base. Thank You both for working on this.

@piponazo piponazo merged commit cd5a3ed into Exiv2:master Aug 23, 2017
@fantasy7082 fantasy7082 mentioned this pull request Sep 24, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@piponazo piponazo piponazo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@a17r @clanmills @piponazo