Fix build and warning with musl libc #615
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only GNU libc has implementation of the GNU variant of strerror_r, so also for __GLIBC__ to determine which strerror_r implemenation to use. This fixes build with musl libc, which makes some, but not all, GNU extensions available with _GNU_SOURCE.
Fix warnings when built with musl libc by using the correct path for errno.h as defined in POSIX. Fixes the following warning: In file included from /home/ncopa/src/exiv2/src/http.cpp:74: /usr/include/sys/errno.h:1:2: warning: #warning redirecting incorrect #include <sys/errno.h> to <errno.h> [-Wcpp] #warning redirecting incorrect #include <sys/errno.h> to <errno.h> ^~~~~~~
|
Seasons Greetings. Thanks for sending this. There's something familiar about this. It'll get integrated next week. Time for a break from Exiv2. |
Codecov Report
@@ Coverage Diff @@
## master #615 +/- ##
=======================================
Coverage 62.61% 62.61%
=======================================
Files 154 154
Lines 21094 21094
=======================================
Hits 13209 13209
Misses 7885 7885
Continue to review full report at Codecov.
|
piponazo
approved these changes
Dec 25, 2018
|
It was Alpine Linux, x86_64, which uses musl libc instead of glibc. |
Merged
This was referenced Jan 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.