Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updating links from rtd to jdox #433

Merged
merged 4 commits into from
Oct 26, 2020
Merged

Conversation

jaymedina
Copy link
Contributor

Last commit! Just a quick update to the link on contam pages.

@jaymedina jaymedina requested a review from mfixstsci October 23, 2020 20:56
Copy link
Contributor

@mfixstsci mfixstsci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @jaymedina -- All of the changes look good. I just tested the links and they both worked just fine. I noticed when I installed the app that exoctk == 1.0.0. Have you rebased since the release?

@pep8speaks
Copy link

Hello @jaymedina, Thank you for updating !

Line 349:27: W504 line break after binary operator
Line 350:18: W504 line break after binary operator
Line 351:34: W504 line break after binary operator
Line 352:18: W504 line break after binary operator

@jaymedina
Copy link
Contributor Author

Hey @mfixstsci , I just merged this branch with the most recent master . I'll merge when checks have passed. Thanks for reviewing!

@jaymedina jaymedina merged commit 1591830 into ExoCTK:master Oct 26, 2020
hover2pi pushed a commit that referenced this pull request Dec 2, 2022
updating links from rtd to jdox
hover2pi pushed a commit that referenced this pull request Jul 16, 2024
updating links from rtd to jdox
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants