Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Web patch #559

Merged
merged 17 commits into from
Mar 7, 2023
Merged

Web patch #559

merged 17 commits into from
Mar 7, 2023

Conversation

hover2pi
Copy link
Member

@hover2pi hover2pi commented Mar 2, 2023

Pins new dependencies and fixes a few bugs in the LDC and contam tool.

@hover2pi hover2pi requested a review from nespinoza March 3, 2023 15:50
@hover2pi
Copy link
Member Author

hover2pi commented Mar 3, 2023

Hi @nespinoza ! I updated a few deprecated package build settings (including renaming several files) and got the builds working. I also found a few Web app bugs that don't get caught in the pytest tests but I found when I tried to test drive it. If you could sign off on this when you get a chance, I'd appreciate it!

@hover2pi
Copy link
Member Author

hover2pi commented Mar 3, 2023

Plus, this has to be merged with develop before develop is merged with master.

@hover2pi hover2pi requested a review from mfixstsci March 6, 2023 14:28
@hover2pi hover2pi merged commit 7074c89 into develop Mar 7, 2023
@hover2pi hover2pi deleted the web_patch branch March 7, 2023 16:24
hover2pi added a commit that referenced this pull request Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants