v1.2.5

[hover2pi]

Modifies the LDC so that the closest model from a grid is selected with a simple function instead of interpolating a heavy precomputed grid.

[mfixstsci]

Hey @hover2pi I just took a look at the files you updated. It looks like you are adding code that uses the older version of the jwst_gtvt (get_table). I am thinking, and let me know what you think, that if we can get #574 we can update this PR with calls to the updated version of the GTVT that way we won't have to go back and update it later!

[mfixstsci]

Hey @hover2pi I see some movement here. Let me know when you are ready for a review!

[pep8speaks]

Hello @hover2pi, Thank you for updating !

• In the file exoctk/contam_visibility/contamination_figure.py:

Line 209:9: E265 block comment should start with '# '
Line 275:5: E265 block comment should start with '# '
Line 297:93: E226 missing whitespace around arithmetic operator

• In the file exoctk/contam_visibility/field_simulator.py:

Line 40:46: E261 at least two spaces before inline comment
Line 43:1: E402 module level import not at top of file
Line 45:162: E231 missing whitespace after ':'
Line 46:164: E231 missing whitespace after ':'
Line 47:165: E231 missing whitespace after ':'
Line 57:1: E302 expected 2 blank lines, found 1
Line 129:32: E226 missing whitespace around arithmetic operator
Line 176:94: E231 missing whitespace after ','
Line 419:51: E261 at least two spaces before inline comment
Line 462:64: E261 at least two spaces before inline comment
Line 463:64: E261 at least two spaces before inline comment
Line 464:64: E261 at least two spaces before inline comment
Line 554:161: E241 multiple spaces after ','
Line 733:16: E261 at least two spaces before inline comment
Line 743:59: E226 missing whitespace around arithmetic operator
Line 1021:9: E303 too many blank lines (2)
Line 1083:18: E261 at least two spaces before inline comment
Line 1083:18: E262 inline comment should start with '# '

• In the file exoctk/contam_visibility/new_vis_plot.py:

Line 20:59: E225 missing whitespace around operator
Line 46:5: E122 continuation line missing indentation or outdented
Line 47:5: E122 continuation line missing indentation or outdented
Line 48:5: E122 continuation line missing indentation or outdented
Line 49:5: E122 continuation line missing indentation or outdented
Line 49:61: E231 missing whitespace after ','
Line 63:121: W291 trailing whitespace
Line 67:47: E226 missing whitespace around arithmetic operator
Line 71:13: W292 no newline at end of file

• In the file exoctk/contam_visibility/visibilityPA.py:

Line 143:26: E712 comparison to False should be 'if cond is False:' or 'if not cond:'
Line 401:28: E261 at least two spaces before inline comment
Line 401:29: E262 inline comment should start with '# '
Line 433:41: W292 no newline at end of file

• In the file exoctk/exoctk_app/app_exoctk.py:

Line 20:1: E265 block comment should start with '# '
Line 406:1: W293 blank line contains whitespace
Line 776:21: W605 invalid escape sequence '('
Line 776:25: W605 invalid escape sequence ')'
Line 776:57: W605 invalid escape sequence '\c'
Line 776:74: W605 invalid escape sequence '\e'
Line 782:46: W605 invalid escape sequence '('
Line 782:48: W605 invalid escape sequence '\l'
Line 782:56: W605 invalid escape sequence '\m'
Line 782:66: W605 invalid escape sequence '\h'
Line 782:79: W605 invalid escape sequence '\m'
Line 782:85: W605 invalid escape sequence ')'
Line 783:46: W605 invalid escape sequence '('
Line 783:48: W605 invalid escape sequence '\l'
Line 783:56: W605 invalid escape sequence '\m'
Line 783:66: W605 invalid escape sequence '\h'
Line 783:79: W605 invalid escape sequence '\m'
Line 783:85: W605 invalid escape sequence ')'
Line 784:46: W605 invalid escape sequence '('
Line 784:48: W605 invalid escape sequence '\l'
Line 784:56: W605 invalid escape sequence '\m'
Line 784:66: W605 invalid escape sequence '\h'
Line 784:79: W605 invalid escape sequence '\m'
Line 784:85: W605 invalid escape sequence ')'
Line 790:58: W605 invalid escape sequence '('
Line 790:62: W605 invalid escape sequence '\m'
Line 790:69: W605 invalid escape sequence '\m'
Line 790:75: W605 invalid escape sequence ')'
Line 815:25: W605 invalid escape sequence '('
Line 815:29: W605 invalid escape sequence ')'
Line 815:61: W605 invalid escape sequence '\c'
Line 815:78: W605 invalid escape sequence '\e'
Line 821:50: W605 invalid escape sequence '('
Line 821:52: W605 invalid escape sequence '\l'
Line 821:60: W605 invalid escape sequence '\m'
Line 821:70: W605 invalid escape sequence '\h'
Line 821:83: W605 invalid escape sequence '\m'
Line 821:89: W605 invalid escape sequence ')'
Line 822:50: W605 invalid escape sequence '('
Line 822:52: W605 invalid escape sequence '\l'
Line 822:60: W605 invalid escape sequence '\m'
Line 822:70: W605 invalid escape sequence '\h'
Line 822:83: W605 invalid escape sequence '\m'
Line 822:89: W605 invalid escape sequence ')'
Line 823:50: W605 invalid escape sequence '('
Line 823:52: W605 invalid escape sequence '\l'
Line 823:60: W605 invalid escape sequence '\m'
Line 823:70: W605 invalid escape sequence '\h'
Line 823:83: W605 invalid escape sequence '\m'
Line 823:89: W605 invalid escape sequence ')'
Line 829:62: W605 invalid escape sequence '('
Line 829:66: W605 invalid escape sequence '\m'
Line 829:73: W605 invalid escape sequence '\m'
Line 829:79: W605 invalid escape sequence ')'

• In the file exoctk/forward_models/forward_models.py:

Line 74:5: E722 do not use bare 'except'

• In the file exoctk/limb_darkening/limb_darkening_fit.py:

Line 104:46: W605 invalid escape sequence '\m'
Line 504:30: W605 invalid escape sequence '\m'
Line 505:32: W605 invalid escape sequence '\m'
Line 505:39: W605 invalid escape sequence '\m'
Line 549:31: E222 multiple spaces after operator

• In the file exoctk/modelgrid.py:

Line 74:43: E226 missing whitespace around arithmetic operator
Line 83:52: E226 missing whitespace around arithmetic operator
Line 83:68: E226 missing whitespace around arithmetic operator
Line 104:23: E226 missing whitespace around arithmetic operator
Line 105:46: E221 multiple spaces before operator
Line 117:38: E261 at least two spaces before inline comment
Line 370:57: W504 line break after binary operator
Line 371:57: W504 line break after binary operator
Line 372:57: W504 line break after binary operator
Line 373:57: W504 line break after binary operator
Line 374:55: W504 line break after binary operator
Line 394:63: W504 line break after binary operator
Line 396:63: W504 line break after binary operator
Line 398:61: W504 line break after binary operator
Line 484:54: W504 line break after binary operator
Line 485:54: W504 line break after binary operator
Line 486:54: W504 line break after binary operator
Line 487:54: W504 line break after binary operator
Line 488:52: W504 line break after binary operator
Line 494:61: W504 line break after binary operator
Line 495:61: W504 line break after binary operator
Line 502:61: W504 line break after binary operator
Line 503:61: W504 line break after binary operator

• In the file exoctk/tests/test_contam_visibility.py:

Line 39:42: E261 at least two spaces before inline comment