Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding pyproject.toml #588

Merged
merged 16 commits into from
May 7, 2024
Merged

Adding pyproject.toml #588

merged 16 commits into from
May 7, 2024

Conversation

mfixstsci
Copy link
Contributor

Addresses #584

@pep8speaks
Copy link

pep8speaks commented Jan 26, 2024

Hello @mfixstsci, Thank you for updating !

Line 59:1: E265 block comment should start with '# '
Line 120:5: E123 closing bracket does not match indentation of opening bracket's line
Line 124:1: E265 block comment should start with '# '
Line 129:1: E265 block comment should start with '# '
Line 132:1: E265 block comment should start with '# '
Line 137:1: E265 block comment should start with '# '
Line 141:1: E265 block comment should start with '# '

Line 19:1: W391 blank line at end of file

Line 6:2: W292 no newline at end of file

Comment last updated at 2024-02-02 15:06:58 UTC

update RTD config to use base conda environment and install from project metadata
.readthedocs.yaml Outdated Show resolved Hide resolved
Co-authored-by: Zach Burnett <zachary.r.burnett@gmail.com>
@mfixstsci
Copy link
Contributor Author

@hover2pi this PR is ready to merge. @zacharyburnett approved the changes and we are ready to go.

'cython',
'docopt',
'docutils',
'flake8',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this is needed in the wheel dependencies (unless it is directly imported by the application at runtime). Are there other dependencies like this that can be removed?

Suggested change
'flake8',

Copy link
Member

@hover2pi hover2pi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent!

@hover2pi hover2pi merged commit 6a3bba5 into ExoCTK:develop May 7, 2024
7 checks passed
hover2pi added a commit that referenced this pull request Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants