Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tier2 Software Standards #590

Merged
merged 7 commits into from
May 7, 2024
Merged

Tier2 Software Standards #590

merged 7 commits into from
May 7, 2024

Conversation

hover2pi
Copy link
Member

This PR includes some small updates to the package to make it compliant with the STScI Community Software Initiative standards.

This was referenced Jan 30, 2024
Closed
Closed
@pep8speaks
Copy link

pep8speaks commented Jan 30, 2024 •
edited
Loading

Hello @hover2pi, Thank you for updating !

Line 209:9: E265 block comment should start with '# '
Line 274:5: E265 block comment should start with '# '
Line 296:93: E226 missing whitespace around arithmetic operator

Comment last updated at 2024-01-30 15:22:56 UTC

@hover2pi hover2pi mentioned this pull request Jan 30, 2024
Closed
@hover2pi hover2pi mentioned this pull request Jan 30, 2024
Closed
@hover2pi hover2pi mentioned this pull request Jan 30, 2024
Closed
@nespinoza nespinoza self-requested a review January 30, 2024 16:30
mfixstsci
mfixstsci approved these changes Jan 31, 2024
View reviewed changes
Copy link
Contributor

@mfixstsci mfixstsci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @hover2pi I am going to put it on the development server for testing and we can get this into develop

@hover2pi hover2pi merged commit de65503 into develop May 7, 2024
0 of 7 checks passed
@hover2pi hover2pi deleted the tier2 branch May 7, 2024 13:38
@hover2pi hover2pi mentioned this pull request Jul 16, 2024
Closed
hover2pi added a commit that referenced this pull request Jul 16, 2024
@hover2pi
Merge pull request #590 from ExoCTK/tier2
2a067aa 
Tier2 Software Standards
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mfixstsci mfixstsci mfixstsci approved these changes

@nespinoza nespinoza Awaiting requested review from nespinoza

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hover2pi @pep8speaks @mfixstsci