Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Atmospheric Retrieval Support #591

Merged
merged 1 commit into from
Feb 27, 2024

Conversation

mfixstsci
Copy link
Contributor

Deleting all files, docs and tests associated with atmospheric retrievals.

@pep8speaks
Copy link

Hello @mfixstsci, Thank you for submitting the Pull Request !

Line 20:1: E265 block comment should start with '# '
Line 391:1: W293 blank line contains whitespace
Line 761:21: W605 invalid escape sequence '('
Line 761:25: W605 invalid escape sequence ')'
Line 761:57: W605 invalid escape sequence '\c'
Line 761:74: W605 invalid escape sequence '\e'
Line 767:46: W605 invalid escape sequence '('
Line 767:48: W605 invalid escape sequence '\l'
Line 767:56: W605 invalid escape sequence '\m'
Line 767:66: W605 invalid escape sequence '\h'
Line 767:79: W605 invalid escape sequence '\m'
Line 767:85: W605 invalid escape sequence ')'
Line 768:46: W605 invalid escape sequence '('
Line 768:48: W605 invalid escape sequence '\l'
Line 768:56: W605 invalid escape sequence '\m'
Line 768:66: W605 invalid escape sequence '\h'
Line 768:79: W605 invalid escape sequence '\m'
Line 768:85: W605 invalid escape sequence ')'
Line 769:46: W605 invalid escape sequence '('
Line 769:48: W605 invalid escape sequence '\l'
Line 769:56: W605 invalid escape sequence '\m'
Line 769:66: W605 invalid escape sequence '\h'
Line 769:79: W605 invalid escape sequence '\m'
Line 769:85: W605 invalid escape sequence ')'
Line 775:58: W605 invalid escape sequence '('
Line 775:62: W605 invalid escape sequence '\m'
Line 775:69: W605 invalid escape sequence '\m'
Line 775:75: W605 invalid escape sequence ')'
Line 800:25: W605 invalid escape sequence '('
Line 800:29: W605 invalid escape sequence ')'
Line 800:61: W605 invalid escape sequence '\c'
Line 800:78: W605 invalid escape sequence '\e'
Line 806:50: W605 invalid escape sequence '('
Line 806:52: W605 invalid escape sequence '\l'
Line 806:60: W605 invalid escape sequence '\m'
Line 806:70: W605 invalid escape sequence '\h'
Line 806:83: W605 invalid escape sequence '\m'
Line 806:89: W605 invalid escape sequence ')'
Line 807:50: W605 invalid escape sequence '('
Line 807:52: W605 invalid escape sequence '\l'
Line 807:60: W605 invalid escape sequence '\m'
Line 807:70: W605 invalid escape sequence '\h'
Line 807:83: W605 invalid escape sequence '\m'
Line 807:89: W605 invalid escape sequence ')'
Line 808:50: W605 invalid escape sequence '('
Line 808:52: W605 invalid escape sequence '\l'
Line 808:60: W605 invalid escape sequence '\m'
Line 808:70: W605 invalid escape sequence '\h'
Line 808:83: W605 invalid escape sequence '\m'
Line 808:89: W605 invalid escape sequence ')'
Line 814:62: W605 invalid escape sequence '('
Line 814:66: W605 invalid escape sequence '\m'
Line 814:73: W605 invalid escape sequence '\m'
Line 814:79: W605 invalid escape sequence ')'

If you have not done so, please consult PEP8 and PEP257

@mfixstsci mfixstsci changed the base branch from main to develop January 30, 2024 21:37
@mfixstsci mfixstsci requested a review from hover2pi January 30, 2024 21:47
@mfixstsci
Copy link
Contributor Author

@nespinoza @hover2pi this is a first pass. Hopefully we catch everything. I am going to fire up the app locally and see what it looks like.

@mfixstsci
Copy link
Contributor Author

Screen Shot 2024-01-30 at 4 50 48 PM

Looks good to me 🤷 let me know if I missed anything.

@nespinoza
Copy link
Collaborator

Suggestion from the meeting today: now that this is going to be merged, test this in tlexoctk1 to triple check everything looks good.

@nespinoza nespinoza merged commit 83720fe into ExoCTK:develop Feb 27, 2024
7 checks passed
hover2pi pushed a commit that referenced this pull request Jul 16, 2024
Remove Atmospheric Retrieval Support
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants