Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds proper motion correction and galaxy support to Contamination tool #597

Merged
merged 1,026 commits into from
Jul 31, 2024

Conversation

hover2pi
Copy link
Member

@hover2pi hover2pi commented May 8, 2024

  • Corrects RA and Dec of sources in contamination tool using proper motion data from Gaia EDR3.
  • Differentiates between stars and galaxies in contamination tool, showing the trace location but not the level of contamination in the galaxy case

bourque and others added 30 commits February 1, 2022 14:21
Bumps [paramiko](https://github.com/paramiko/paramiko) from 2.7.2 to 2.10.1.
- [Release notes](https://github.com/paramiko/paramiko/releases)
- [Changelog](https://github.com/paramiko/paramiko/blob/main/NEWS)
- [Commits](paramiko/paramiko@2.7.2...2.10.1)

---
updated-dependencies:
- dependency-name: paramiko
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
Merging develop into master for v1.2.4 release
@pep8speaks
Copy link

pep8speaks commented May 8, 2024

Hello @hover2pi, Thank you for updating !

Line 47:46: E261 at least two spaces before inline comment
Line 50:1: E402 module level import not at top of file
Line 52:162: E231 missing whitespace after ':'
Line 53:164: E231 missing whitespace after ':'
Line 54:165: E231 missing whitespace after ':'
Line 64:1: E302 expected 2 blank lines, found 1
Line 136:34: E226 missing whitespace around arithmetic operator
Line 191:94: E231 missing whitespace after ','
Line 456:51: E261 at least two spaces before inline comment
Line 499:64: E261 at least two spaces before inline comment
Line 500:64: E261 at least two spaces before inline comment
Line 501:64: E261 at least two spaces before inline comment
Line 591:161: E241 multiple spaces after ','
Line 840:16: E261 at least two spaces before inline comment
Line 850:59: E226 missing whitespace around arithmetic operator
Line 1128:9: E303 too many blank lines (2)
Line 1190:18: E261 at least two spaces before inline comment
Line 1190:18: E262 inline comment should start with '# '

Line 103:46: W605 invalid escape sequence '\m'
Line 503:30: W605 invalid escape sequence '\m'
Line 504:32: W605 invalid escape sequence '\m'
Line 504:39: W605 invalid escape sequence '\m'
Line 548:31: E222 multiple spaces after operator

Comment last updated at 2024-05-08 22:01:37 UTC

@hover2pi hover2pi changed the title Added proper motion correction to contam tool Adds proper motion correction and galaxy support to Contamination tool May 8, 2024
@hover2pi hover2pi self-assigned this Jul 2, 2024
@hover2pi hover2pi requested a review from mfixstsci July 17, 2024 13:43
@mfixstsci
Copy link
Contributor

@hover2pi just looked at the files and noticed that you are adding validation to a form and removing hotsoss?

@hover2pi
Copy link
Member Author

hover2pi commented Jul 17, 2024

@mfixstsci Yes, I found an error in the Fortney form validation and added a fix to the server error we were getting when someone submits a form with blank fields. Unrelatedly, I removed hotsoss as a dependency and moved the relevant code into the contam tool. This should allow us to unpin the bokeh version I think.

@hover2pi hover2pi merged commit f4b3d58 into develop Jul 31, 2024
7 checks passed
@hover2pi hover2pi deleted the contam_updates branch July 31, 2024 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants