Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: bump atoms #16

Merged
merged 2 commits into from
Jan 24, 2024
Merged

refactor: bump atoms #16

merged 2 commits into from
Jan 24, 2024

Conversation

mvayngrib
Copy link
Collaborator

@mvayngrib mvayngrib commented Jan 9, 2024

summary

depends on #15

test plan

(updated)
6.0.0 -> 7.0.0 was technically a breaking change, but in practice just fixes crashes in serialization https://github.com/ExodusMovement/exodus-hydra/pull/4896
the 7.0.0 -> 7.0.1 patch is adding the missing delay dep, so no testing should be necessary

diegomura
diegomura previously approved these changes Jan 9, 2024
Copy link
Contributor

@diegomura diegomura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

sparten11740
sparten11740 previously approved these changes Jan 10, 2024
@mvayngrib mvayngrib force-pushed the mv/keychain-dev-deps branch from f273fa8 to dbbbe85 Compare January 23, 2024 21:30
Base automatically changed from mv/keychain-dev-deps to master January 23, 2024 21:32
@mvayngrib mvayngrib dismissed stale reviews from sparten11740 and diegomura January 23, 2024 21:32

The base branch was changed.

Copy link
Contributor

@diegomura diegomura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@mvayngrib mvayngrib merged commit ecdf917 into master Jan 24, 2024
3 of 8 checks passed
@mvayngrib mvayngrib deleted the mv/bump-atoms branch January 24, 2024 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants