Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: expose sodium.sign #161

Merged
merged 2 commits into from
Oct 17, 2024
Merged

feat: expose sodium.sign #161

merged 2 commits into from
Oct 17, 2024

Conversation

sparten11740
Copy link
Contributor

@sparten11740 sparten11740 commented Oct 17, 2024 •
edited
Loading

exposing sodium.sign is required for seedless

@sparten11740 sparten11740 self-assigned this Oct 17, 2024
kewde
kewde approved these changes Oct 17, 2024
View reviewed changes
Copy link
Contributor

@kewde kewde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

can be achieved using signDetached and prepending the sigature etc, but this is nice as well.

@sparten11740 sparten11740 merged commit 457d201 into master Oct 17, 2024
8 checks passed
@sparten11740 sparten11740 deleted the sparten11740/feat/expose-sodium-sign branch October 17, 2024 15:38
@mvayngrib mvayngrib requested a review from ChALkeR October 17, 2024 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kewde kewde kewde approved these changes

@diegomura diegomura Awaiting requested review from diegomura diegomura is a code owner

@mvayngrib mvayngrib Awaiting requested review from mvayngrib mvayngrib is a code owner

@ChALkeR ChALkeR Awaiting requested review from ChALkeR

Assignees

@sparten11740 sparten11740

Labels
feature keychain
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sparten11740 @kewde