-
Notifications
You must be signed in to change notification settings - Fork 5
feat: add TypeScript types for base58check.js #33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: ChALkeR <291301+ChALkeR@users.noreply.github.com>
Co-authored-by: ChALkeR <291301+ChALkeR@users.noreply.github.com>
Co-authored-by: ChALkeR <291301+ChALkeR@users.noreply.github.com>
Co-authored-by: ChALkeR <291301+ChALkeR@users.noreply.github.com>
c84154e to
9ac5a57
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adds comprehensive TypeScript type definitions for the base58check.js module, which implements base58check encoding (commonly used in Bitcoin addresses). The types follow the established patterns in the codebase and include proper JSDoc documentation.
Changes:
- Added
base58check.d.tswith complete type definitions for all exported functions and interfaces - Updated
package.jsonto include the new type definition file in exports and files array - Enhanced README documentation with detailed descriptions for each base58check function
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| base58check.d.ts | Comprehensive TypeScript type definitions for base58check module including async/sync variants and factory function |
| package.json | Added base58check.d.ts to files array and types field to base58check.js export configuration |
| README.md | Added descriptive documentation for all base58check functions explaining their behavior |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Plan: Add TypeScript types for base58check.js
toBase58check(async)fromBase58check(async)toBase58checkSync(sync)fromBase58checkSync(sync)makeBase58checkfactory functionSummary
Successfully added comprehensive TypeScript type definitions for
base58check.jsfollowing the existing patterns in the codebase. All tests pass, code review complete, and no security issues detected. Removed unrelated .gitignore change as requested.Original prompt
base58check.js#27💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.