Merged
Conversation
kewdex
suggested changes
Jan 22, 2026
package-lock.json
Outdated
Contributor
There was a problem hiding this comment.
@copilot remove this file, we use pnpm
Contributor
Author
Done in commits e3852ec and 46052ee:
|
e3852ec to
46d9702
Compare
Co-authored-by: ChALkeR <291301+ChALkeR@users.noreply.github.com>
Co-authored-by: ChALkeR <291301+ChALkeR@users.noreply.github.com>
…sion' Co-authored-by: ChALkeR <291301+ChALkeR@users.noreply.github.com>
46d9702 to
c0aeff7
Compare
ChALkeR
reviewed
Jan 22, 2026
wif.d.ts
Outdated
| * Also no inconsistent behavior on Buffer/Uint8Array input. | ||
| * | ||
| * ```js | ||
| * import { fromWifString, toWifString, fromWifStringSync, toWifStringSync } from '@exodus/bytes/wif.js' |
Co-authored-by: ChALkeR <291301+ChALkeR@users.noreply.github.com>
ChALkeR
approved these changes
Jan 22, 2026
There was a problem hiding this comment.
Pull request overview
This PR adds TypeScript type definitions for the wif.js module, following the established patterns used by other modules in the repository (such as base58check.d.ts, base64.d.ts, etc.).
Changes:
- Created comprehensive TypeScript type definitions in
wif.d.tswith JSDoc documentation for all exported functions - Updated
package.jsonto includewif.d.tsin the files list and added types export configuration - Enhanced README.md with detailed function documentation including descriptions, parameters, return values, and error conditions
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| wif.d.ts | Adds TypeScript type definitions for the Wif interface and all exported functions (fromWifString, fromWifStringSync, toWifString, toWifStringSync) with comprehensive JSDoc documentation |
| package.json | Adds wif.d.ts to the files list and configures the types export for ./wif.js module |
| README.md | Enhances documentation for WIF functions with detailed descriptions, parameter documentation, and behavior specifications |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add TypeScript types for wif.js ✅
wif.d.tswith type definitions for all exported functionswif.d.tsto package.json files list./wif.jsSummary
Successfully added TypeScript type definitions for the
wif.jsmodule, following the same pattern as other modules in the repository (e.g.,base64.d.ts,hex.d.ts,base32.d.ts).Updated README.md with comprehensive documentation for all WIF functions including descriptions, parameters, return values, and error conditions. Parameter names now match the actual implementation.
Import syntax in the type definitions now matches the README exactly (split into two import statements).
Security Summary: No vulnerabilities discovered.
Original prompt
wif.js#29✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.