Add custom timeInTopic metric to timeseries-aggregator #172
Conversation
Codecov Report
@@ Coverage Diff @@
## master #172 +/- ##
=======================================
Coverage ? 0%
=======================================
Files ? 30
Lines ? 36
Branches ? 6
=======================================
Hits ? 0
Misses ? 36
Partials ? 0
Continue to review full report at Codecov.
|
| @@ -52,6 +53,8 @@ class WindowedMetric private(var windowedMetricsMap: mutable.TreeMap[TimeWindow, | |||
| * @param incomingMetricData - incoming metric data | |||
| */ | |||
| def compute(incomingMetricData: MetricData): Unit = { | |||
| timeInTopicMetricPointHistogram.update(incomingMetricData.getTimestamp() - System.currentTimeMillis()) | |||
There was a problem hiding this comment.
Is incomingMetricData.getTimestamp() is in micros?
There was a problem hiding this comment.
You know, I'm not sure, let me double check
There was a problem hiding this comment.
It looks like the MetricDataTransformer object converts the span's microseconds to seconds
https://github.com/ExpediaDotCom/haystack-trends/blob/master/span-timeseries-transformer/src/main/scala/com/expedia/www/haystack/trends/transformer/MetricDataTransformer.scala#L41
There was a problem hiding this comment.
I'll update my PR with that info
This PR adds a new metric that measures the amount of time between a given span's creation timestamp and the point at which it is consumed as part of trends creation.
Our goal is to be able to demonstrate the amount of time between the time an app submits a trace and the time it takes to generate trends off of it is underneath a certain upper bound.