fix: Populates project created_time correctly according to created time in feast_metadata table #149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EXPEbdodla
changed the title
zabarn
reviewed
Oct 24, 2024
Comment on lines
-295
to
+297
| feast_metadata_projects.append(row._mapping["project_id"]) | ||
| feast_metadata_projects[row._mapping["project_id"]] = int( | ||
| row._mapping["last_updated_timestamp"] | ||
| ) |
There was a problem hiding this comment.
Can you explain what this is doing? I don't really follow
There was a problem hiding this comment.
Feast is deprecating feast_metadata table in the favor of projects. We are doing a sync of projects from feast_metadata to projects table. Earlier we are creating projects but missing the create timestamp from feast_metadata to projects. It creates inconsistencies in registry. This fix avoids that inconsistency.
zabarn
approved these changes
Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Populates project created_time correctly according to created time in feast_metadata table.
Which issue(s) this PR fixes:
Misc