Support built-in ID type serialization in GraphQLServerRequest
#1958
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…1952) ### 📝 Description #### Problem after graphql-kotlin 7.1.0, the following `GraphQLRequest` our team uses started to fail. ```kotlin GraphQLRequest( "query(${'$'}id: ID!) { ... }", variables = mapOf("id" to ID("1")) ) ``` this is because `kotlinx.serialization` is recently introduced instead of Jackson, but `ID` serialization is missing, so it is converted to `JsonNull`. since `ID` is built-in scalar type, i think `ID` serialization should be supported. #### Solution add serialization logic to `AnyNullableKSerializer` ### 🔗 Related Issues N/A
dariuszkuc
changed the title
ID type serialization in GraphQLServerRequest (#1952)ID type serialization in GraphQLServerRequest
dariuszkuc
added
type: bug
dariuszkuc
approved these changes
Apr 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #1952 to v7