[server] update default GraphQLContext #955
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some time ago we updated our `GraphQLContext` parameter handling logic from requiring explicit `@GraphQLContext` parameter annotation to requiring context classes to implement our marker interface but we never updated our fallback logic. By default, `spring-server` created `EmptyGraphQLContext` context factory with a fallback to `graphql-java` `GraphQLContext` that could never be specified as function parameter as it (obviously) did not implement our interface. Updating default generated `GraphQLContext` to more usable `DefaultGraphQLContext` that holds concurrent hash map of arbitrary elements (similar to `graphql-java` default).
dariuszkuc
added
type: bug
smyrick
approved these changes
Dec 3, 2020
huehnerlady
pushed a commit
to huehnerlady/graphql-kotlin
that referenced
this pull request
Apr 27, 2021
Some time ago we updated our `GraphQLContext` parameter handling logic from requiring explicit `@GraphQLContext` parameter annotation to requiring context classes to implement our marker interface but we never updated our fallback logic. By default, `spring-server` created `EmptyGraphQLContext` context factory with a fallback to `graphql-java` `GraphQLContext` that could never be specified as function parameter as it (obviously) did not implement our interface. Updating default generated `GraphQLContext` to more usable `DefaultGraphQLContext` that holds concurrent hash map of arbitrary elements (similar to `graphql-java` default).
dariuszkuc
added a commit
to dariuszkuc/graphql-kotlin
that referenced
this pull request
Aug 5, 2022
Some time ago we updated our `GraphQLContext` parameter handling logic from requiring explicit `@GraphQLContext` parameter annotation to requiring context classes to implement our marker interface but we never updated our fallback logic. By default, `spring-server` created `EmptyGraphQLContext` context factory with a fallback to `graphql-java` `GraphQLContext` that could never be specified as function parameter as it (obviously) did not implement our interface. Updating default generated `GraphQLContext` to more usable `DefaultGraphQLContext` that holds concurrent hash map of arbitrary elements (similar to `graphql-java` default).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
Some time ago we updated our
GraphQLContextparameter handling logic from requiring explicit@GraphQLContextparameter annotation to requiring context classes to implement our marker interface but we never updated our fallback logic. By default,spring-servercreatedEmptyGraphQLContextcontext factory with a fallback tographql-javaGraphQLContextthat could never be specified as function parameter as it (obviously) did not implement our interface.Updating default generated
GraphQLContextto more usableDefaultGraphQLContextthat holds concurrent hash map of arbitrary elements (similar tographql-javadefault).🔗 Related Issues
Issue found in #945