[server] add support for flow subscriptions #972
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`FlowSubscriptionExecutionStrategy` was available in the schema-generator library but we never integrated it with the spring-server. Since all our subscription handlers are based on the publisher API, I also updated flow subscription strategy to return publisher as well. This is a breaking for the existing flow subscription strategy users but without this change we would need to rewrite all our subscription handling logic to support flow natively (which we should do eventually when/if we move away from `graphql-java` based execution). Explicit casts are required due to the type erasure and also Java reliance on site-variance vs Kotlin declaration-variance.
dariuszkuc
added
changes: major
smyrick
approved these changes
Dec 16, 2020
huehnerlady
pushed a commit
to huehnerlady/graphql-kotlin
that referenced
this pull request
Apr 27, 2021
* [server] add support for flow subscriptions `FlowSubscriptionExecutionStrategy` was available in the schema-generator library but we never integrated it with the spring-server. Since all our subscription handlers are based on the publisher API, I also updated flow subscription strategy to return publisher as well. This is a breaking for the existing flow subscription strategy users but without this change we would need to rewrite all our subscription handling logic to support flow natively (which we should do eventually when/if we move away from `graphql-java` based execution). Explicit casts are required due to the type erasure and also Java reliance on site-variance vs Kotlin declaration-variance. * update docs
dariuszkuc
added a commit
to dariuszkuc/graphql-kotlin
that referenced
this pull request
Aug 5, 2022
* [server] add support for flow subscriptions `FlowSubscriptionExecutionStrategy` was available in the schema-generator library but we never integrated it with the spring-server. Since all our subscription handlers are based on the publisher API, I also updated flow subscription strategy to return publisher as well. This is a breaking for the existing flow subscription strategy users but without this change we would need to rewrite all our subscription handling logic to support flow natively (which we should do eventually when/if we move away from `graphql-java` based execution). Explicit casts are required due to the type erasure and also Java reliance on site-variance vs Kotlin declaration-variance. * update docs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
FlowSubscriptionExecutionStrategywas available in the schema-generator library but we never integrated it with the spring-server. Since all our subscription handlers are based on the publisher API, I also updated flow subscription strategy to return publisher as well. This is a breaking for the existing flow subscription strategy users but without this change we would need to rewrite all our subscription handling logic to support flow natively (which we should do eventually when/if we move away fromgraphql-javabased execution).Explicit casts are required due to the type erasure and also Java reliance on site-variance vs Kotlin declaration-variance.
🔗 Related Issues
#358
#970