This repository was archived by the owner on Jun 15, 2021. It is now read-only.
Fix date and timestamp conversion#16
Merged
cmathiesen merged 1 commit intoExpediaGroup:hive-filter-pushdownfrom Aug 31, 2020
Merged
Fix date and timestamp conversion#16cmathiesen merged 1 commit intoExpediaGroup:hive-filter-pushdownfrom
cmathiesen merged 1 commit intoExpediaGroup:hive-filter-pushdownfrom
Conversation
|
Thank you very much for helping with all the Timestamp/Date stuff, it all looks good! I think theres just one checkstyle issue with an unused import on the test class which I'll push a change for after merging this :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes problems with Date and Timestamp conversion:
This converts directly and fixes the tests using Iceberg literals. The timestamp test was updated to create a Timestamp to pass into Hive directly from a known value in microseconds because parsing is dependent on the local zone. That dependency is okay when Hive is running, but we need a Timestamp with a known UTC instant for the test.