Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove HttpClient interface from Styx API #179

Merged
merged 5 commits into from
Jun 11, 2018
Merged

Remove HttpClient interface from Styx API #179

merged 5 commits into from
Jun 11, 2018
+641 −1,010

Conversation

mikkokar
Copy link
Contributor

Removes HttpClient from Styx API.

In the styx-client API:

  • Add new FullHttpClient interface (figure out a better name please)
  • Provide HttpClient interface
  • Remove URL Connection HTTP Client
  • Rename and Modify Simple(Netty)HttpClient so that it can be used in place of URL Connection HTTP Client. (Note that a little discrepancy still exists. A separate instances have to be configured for HTTP and HTTPs variants.)

mikkokar added 5 commits June 8, 2018 16:06
@mikkokar
Replace HttpClient with HttpHandler:
f4e7c31 
- RemoteHost interface. Remove `HttpClient` interface from
  the `hostClient()` API signature.

- Remove a reference to `HttpClient` interface from `BackendServicesRouter`.

Remove `HttpClient` dependency from `RemoteHost` class.
@mikkokar
Organised imports as per code review comments.
b6a45be
@mikkokar
Add FullHttpClient interface and convert SimpleNettyHttpClient.
eca38e5 
Move FullHttpClient interface to styx-client module.
Remove UrlConnectionHttpClient.
Rename SimpleNettyHttpClient to SimpleHttpClient.
@mikkokar
Move HttpClient interface to styx-client module.
5f6af91
@mikkokar
Restore TimeoutsSpec.
1ea2e75
@mikkokar mikkokar requested review from dvlato and kvosper June 11, 2018 07:26
@mikkokar mikkokar merged commit 4f504be into ExpediaGroup:styx-1.0-dev Jun 11, 2018
@mikkokar mikkokar deleted the full-http-client branch June 11, 2018 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dvlato dvlato dvlato approved these changes

@kvosper kvosper Awaiting requested review from kvosper

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mikkokar @dvlato