Allow custom plugin loader injection #213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikkokar
approved these changes
Jul 12, 2018
There was a problem hiding this comment.
For the record: @fantayeneh wants to use a custom plugin loader because they need to share expensively created objects between the plugins.
mikkokar
added a commit
to mikkokar/styx
that referenced
this pull request
Jul 13, 2018
(cherry picked from commit 281d716)
mikkokar
added a commit
that referenced
this pull request
Jul 13, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR addresses the following issue.
The problem
We want the ability to use a custom
PluginsLoaderthat is not sourced from the yaml configs.Detailed description
Right now the method that allow injecting a custom
PluginsLoaderin the styx system is package privatehttps://github.com/HotelsDotCom/styx/blob/41238747919cbe7acf937b6268bfd94aa935a240/components/proxy/src/main/java/com/hotels/styx/startup/StyxServerComponents.java#L144-L148
Acceptance criteria
• A developer should be able to inject a custom
PluginsLoaderwhen building a styx server