Build Styx Docker image using fabric8 docker maven plugin #542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OwenLindsell
approved these changes
Nov 27, 2019
dvlato
approved these changes
Nov 27, 2019
Makefile
Outdated
| cp `find distribution/target -maxdepth 1 -name "styx*linux-x86_64.zip"` ${DOCKER_CONTEXT}/styx.zip | ||
| cp docker/styx-image/* ${DOCKER_CONTEXT} | ||
| docker build -t styxcore:latest --build-arg STYX_IMAGE=styx.zip ${DOCKER_CONTEXT}/. | ||
| mvn clean install -Prelease,linux,docker -Dmaven.test.skip=true |
There was a problem hiding this comment.
do we need mvn clean even though there's a 'clean' above?
There was a problem hiding this comment.
No. Thanks for spotting 👍
distribution/pom.xml
Outdated
| <alias>styxcore</alias> | ||
| <name>${styxcore.docker.image}</name> | ||
| <build> | ||
| <dockerFile>${project.basedir}/../docker/styx-image/Dockerfile</dockerFile> |
There was a problem hiding this comment.
we probably can reference the parent project here instead of using ${project.basedir}/../
There was a problem hiding this comment.
I have changed this to ${project.parent.basedir}.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
fabric8docker maven plugin to build Styx Core docker image.This is to simplify and "abstract away" the details how to build Styx Docker image automatically from other projects.