Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove RxJava - Part 5 #564

Merged
merged 1 commit into from
Dec 16, 2019
Merged

Remove RxJava - Part 5 #564

merged 1 commit into from
Dec 16, 2019

Conversation

OwenLindsell
Copy link
Contributor

No description provided.

@OwenLindsell OwenLindsell changed the title Remove RxJava Remove RxJava - Part 5 Dec 11, 2019
mikkokar
mikkokar reviewed Dec 12, 2019
View reviewed changes
...onents/server/src/main/java/com/hotels/styx/server/netty/connectors/HttpPipelineHandler.java
}
);
Eventual<LiveHttpResponse> responseEventual = httpPipeline.handle(v11Request, newInterceptorContext(ctx));
responseEventual.subscribe(new BaseSubscriber<LiveHttpResponse>() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would consider inlining responseEventual.

mikkokar
mikkokar approved these changes Dec 12, 2019
View reviewed changes
Copy link
Contributor

@mikkokar mikkokar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks okay.

However I would consider contributing StandardHttpPipeline and HttpPipelineHandler as separate PRs. Then, if something breaks the underlying issue will be easier to isolate.

@OwenLindsell OwenLindsell merged commit bdb7de6 into ExpediaGroup:master Dec 16, 2019
@OwenLindsell OwenLindsell mentioned this pull request Mar 27, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikkokar mikkokar mikkokar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@OwenLindsell @mikkokar