Add support for the SameSite cookie attribute. #607
Conversation
components/api/src/main/java/com/hotels/styx/api/ClientCookieDecoder.java
Show resolved
Hide resolved
| * | ||
| * @see ClientCookieEncoder | ||
| */ | ||
| public final class ClientCookieDecoder { |
There was a problem hiding this comment.
This class needs to be package private, ideally.
There was a problem hiding this comment.
All external references removed and it's package private now (so we are using Netty's original ClientCookieDecoder in some tests).
components/api/src/main/java/com/hotels/styx/api/ClientCookieDecoder.java
Outdated
Show resolved
Hide resolved
| @@ -81,7 +77,8 @@ public String encode(String name, String value) { | |||
| * @param cookie the cookie | |||
| * @return a single Set-Cookie header value | |||
| */ | |||
| public String encode(Cookie cookie) { | |||
| public String encode(NettyCookie cookie) { | |||
There was a problem hiding this comment.
This could possibly be package private.
| @@ -146,7 +147,7 @@ public String encode(Cookie cookie) { | |||
| * @param cookies a bunch of cookies | |||
| * @return the corresponding bunch of Set-Cookie headers | |||
| */ | |||
| public List<String> encode(Cookie... cookies) { | |||
| public List<String> encode(NettyCookie... cookies) { | |||
There was a problem hiding this comment.
This could be package private too, AFAICS.
| @@ -194,20 +195,20 @@ public String encode(Cookie cookie) { | |||
| * @param cookies a bunch of cookies | |||
| * @return the corresponding bunch of Set-Cookie headers | |||
| */ | |||
| public List<String> encode(Iterable<? extends Cookie> cookies) { | |||
| Iterator<? extends Cookie> cookiesIt = requireNonNull(cookies, "cookies").iterator(); | |||
| public List<String> encode(Iterable<? extends NettyCookie> cookies) { | |||
There was a problem hiding this comment.
Possibly all these encode methods could be package private.
|
|
||
| client.send( | ||
| get("/") | ||
| .header(HttpHeaderNames.HOST, styxServer().proxyHttpHostHeader()) |
| @@ -286,7 +286,7 @@ class OriginsFileCompatibilitySpec : FunSpec() { | |||
| } | |||
| } | |||
|
|
|||
| test("!TLS Settings modifications") { | |||
| test("TLS Settings modifications") { | |||
There was a problem hiding this comment.
Let's keep this disabled.
|
I wonder if you are interested in contributing something like this back into netty... |
@a-dlatorre I bet you will be looking into this? |
This PR handles issue #604 . Description of the attribute:
https://web.dev/samesite-cookies-explained/