Skip to content

Commit

Permalink
Update from peer review comments
Browse files Browse the repository at this point in the history
  • Loading branch information
AndrewGable committed Sep 2, 2022
1 parent 3fb05a4 commit 092432f
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 6 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -144,13 +144,13 @@ GitHubUtils.octokit.pulls.get({
if (comment.includes(completedContributorChecklist.replace(whitespace, ''))) {
contributorChecklistComplete = true;
} else if (comment.includes('- [')) {
printUncheckedItems(combinedData[i], completedContributorChecklist);
printUncheckedItems(combinedData[i]);
}

if (comment.includes(completedContributorPlusChecklist.replace(whitespace, ''))) {
contributorPlusChecklistComplete = true;
} else if (comment.includes('- [')) {
printUncheckedItems(combinedData[i], completedContributorPlusChecklist);
printUncheckedItems(combinedData[i]);
}
}

Expand All @@ -164,5 +164,5 @@ GitHubUtils.octokit.pulls.get({
return;
}

console.log('All checklist are complete 🎉');
console.log('All checklists are complete 🎉');
});
6 changes: 3 additions & 3 deletions .github/actions/javascript/contributorChecklist/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -154,13 +154,13 @@ GitHubUtils.octokit.pulls.get({
if (comment.includes(completedContributorChecklist.replace(whitespace, ''))) {
contributorChecklistComplete = true;
} else if (comment.includes('- [')) {
printUncheckedItems(combinedData[i], completedContributorChecklist);
printUncheckedItems(combinedData[i]);
}

if (comment.includes(completedContributorPlusChecklist.replace(whitespace, ''))) {
contributorPlusChecklistComplete = true;
} else if (comment.includes('- [')) {
printUncheckedItems(combinedData[i], completedContributorPlusChecklist);
printUncheckedItems(combinedData[i]);
}
}

Expand All @@ -174,7 +174,7 @@ GitHubUtils.octokit.pulls.get({
return;
}

console.log('All checklist are complete 🎉');
console.log('All checklists are complete 🎉');
});


Expand Down

0 comments on commit 092432f

Please sign in to comment.