Skip to content

Commit

Permalink
fix(selection-list): make showTooltip required
Browse files Browse the repository at this point in the history
  • Loading branch information
thiagobrez committed Aug 30, 2023
1 parent 5c67b87 commit 0b2d4b4
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 3 deletions.
1 change: 0 additions & 1 deletion src/components/SelectionList/BaseSelectionList.js
Original file line number Diff line number Diff line change
Expand Up @@ -266,7 +266,6 @@ function BaseSelectionList({
isFocused={isFocused}
isDisabled={isDisabled}
onSelectRow={() => selectRow(item, index)}
showTooltip={showTooltip}
/>
);
};
Expand Down
2 changes: 1 addition & 1 deletion src/components/SelectionList/UserListItem.js
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ import themeColors from '../../styles/themes/default';
import Tooltip from '../Tooltip';
import UserDetailsTooltip from '../UserDetailsTooltip';

function UserListItem({item, isFocused = false, showTooltip = false, onSelectRow, onDismissError = () => {}}) {
function UserListItem({item, isFocused = false, showTooltip, onSelectRow, onDismissError = () => {}}) {
const hasError = !_.isEmpty(item.errors);

const avatar = (
Expand Down
2 changes: 1 addition & 1 deletion src/components/SelectionList/selectionListPropTypes.js
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ const userListItemPropTypes = {
isFocused: PropTypes.bool,

/** Whether this item should show Tooltip */
showTooltip: PropTypes.bool,
showTooltip: PropTypes.bool.isRequired,

/** Callback to fire when the item is pressed */
onSelectRow: PropTypes.func.isRequired,
Expand Down

0 comments on commit 0b2d4b4

Please sign in to comment.